feat: metadata service: make turnserver socket path configurable#840
feat: metadata service: make turnserver socket path configurable#840feld wants to merge 1 commit into
Conversation
|
There were no real tests for the turnserver metadata stuff that I could see, so I included that, but I have no real experience with python test framework so that part was vibed but it looks like how I'd do things in other languages. If someone with actual experience in Python tests could review it that would be great |
686edc4 to
0b21b83
Compare
adbenitez
left a comment
There was a problem hiding this comment.
lgtm, I didn't test but the change is simple and straightforward: just adding a new configuration option for a path instead of using a hard-coded value, can't say much about the tests tho better if someone with more deep understanding of the current tests machinery also take a look at it, the use of sleep give me a bad feeling, I didn't check if other tests also do this
There was a problem hiding this comment.
I'm slightly conflicted about this PR.
The additional config option looks innocent enough, it's a bit annoying to add new config options for small things which operators are only expected to edit with alternative deployment options, but fine with me if the chef cookbook needs this. I think my preference is saying "please rebase this on top of #853 so we don't have to put this option into the default-generated chatmail.ini, and can just set a default in config.py for everyone who doesn't need to think about this".
But then there is also the LLM-generated tests; you don't understand what they do, I don't understand what they do, they have some sketchy sleep statement in it... If they were in a separate PR, this one would be long approved.
Also, please fix the lint errors :) https://github.com/chatmail/relay/actions/runs/22113484762/job/63915452488?pr=840
hpk42
left a comment
There was a problem hiding this comment.
thanks. please simplify the PR along the review comments.
|
@feld looks like merge conflicts you may want to remediate, and bring in latest default into trunk |
|
rebased, simplified. It looks right at first glance but needs a real review. |
|
i took your idea and cleaned up the turnserver tests see #968 |
…erver code. this is originally motivated by #840
|
k, #968 is merged. If you need further discussion, feel free to chat me up :) |
also add tests for the turnserver metadata
Fixes #779